Opened on 06/21/2016 at 01:36:32 PM
Closed on 10/23/2018 at 10:19:25 AM
#4177 closed change (rejected)
Create FilterEngineTest.testSubscriptionProperties test
Reported by: | asmirnov | Assignee: | asmirnov |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | rjeschke | Blocked By: | |
Blocking: | #4031 | Platform: | Android |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Due to missing Subscription.setProperty() it's impossible to do the test similar to https://hg.adblockplus.org/libadblockplus/file/tip/test/FilterEngine.cpp#l167.
smth like
@Test public void testSubscriptionProperties() { Subscription subscription = filterEngine.getSubscription("foo"); assertTrue(subscription.getProperty("stringFoo").isUndefined()); assertTrue(subscription.getProperty("intFoo").isUndefined()); assertTrue(subscription.getProperty("boolFoo").isUndefined()); // TODO : since there is no setProperty finish the test later }
Attachments (0)
Change History (3)
comment:1 Changed on 06/21/2016 at 01:52:55 PM by asmirnov
- Ready set
comment:2 Changed on 06/21/2016 at 01:55:23 PM by asmirnov
- Platform changed from Unknown / Cross platform to Android
comment:3 Changed on 10/23/2018 at 10:19:25 AM by asmirnov
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
The tests are rewritten, the issue is deprecated.