Opened on 06/30/2016 at 11:42:24 AM

Last modified on 10/23/2018 at 10:23:34 AM

#4207 new change

Lower case of HTTP header names in compat.js rather than in each implementation module

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Libadblockplus Keywords: goodfirstbug
Cc: fhd, asmirnov Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

When the user queries for the header value, the case of header name is ​lowered , to support it we lower the case in each implementation of HTTP requests (​1, ​2). It would be better to make the lowering instead in ​compat.js at least for consistency, so we do the lowering in one place by the same function (String.prototype.toLowerCase).

What to change

  • lower the case of all header names in ​compat.js
  • remove lowering from WebRequest implementations.

Attachments (0)

Change History (3)

comment:1 Changed on 06/30/2016 at 11:43:10 AM by sergz

  • Summary changed from lower case HTTP header names in compat.js rather than in each implementation module to Lower case of HTTP header names in compat.js rather than in each implementation module

comment:2 Changed on 06/30/2016 at 11:48:56 AM by asmirnov

  • Blocking 4202 added

comment:3 Changed on 10/23/2018 at 10:23:34 AM by asmirnov

  • Blocking 4202 removed

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.