Opened on 07/22/2016 at 12:47:15 PM
Closed on 04/17/2017 at 07:09:03 AM
Last modified on 04/17/2017 at 07:09:34 AM
#4260 closed change (rejected)
Replace Apache Commons Lang classes
Reported by: | asmirnov | Assignee: | asmirnov |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | rjeschke, fhd | Blocked By: | #4030 |
Blocking: | Platform: | Android | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Currently we're using Apache Commons Lang classes in libadblockplus-android (https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/src/org/apache/commons/lang) and adblockplusandroid (https://hg.adblockplus.org/adblockplusandroid/file/tip/src/org/apache/commons/lang).
We need to rewrite it because of possible licensing issue and codestyle (discussed with Rene).
What to change
org/apache/commons/lang classes.
Also we need to investigate if it's used in library or proxy app only and possibly move it to proxy app repo.
Attachments (0)
Change History (3)
comment:1 Changed on 08/02/2016 at 09:56:23 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/17/2017 at 07:09:03 AM by asmirnov
- Resolution set to rejected
- Status changed from reviewing to closed
since proxy app is not supported any more there is no need to implement the changes.