Opened on 05/10/2016 at 12:28:41 PM
Closed on 10/23/2018 at 10:25:14 AM
#4030 closed change (fixed)
Move JNI bindings into separate library project
Reported by: | rjeschke | Assignee: | asmirnov |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Adblock-Plus-for-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #4031, #4115, #4260 | Platform: | Android |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
The proxy application for Android contains JNI bindings for libadblockplus. As we do have users that use those JNI bindings in their own projects, it would be convenient to have those inside a separate project.
What to change
Create a library project (libadblockplus-android), compatible with gradle, maven and manual importing. Move the JNI specific parts from adblockplusandroid into the new project.
Things of importance for moving:
- the whole `org.adblockplus.libadblockplus' package
- ensure_dependencies.py with buildtools and jni/libadblockplus-binaries
- the jni folder
For the initial version of this library, no code should be modified except that it is needed for the library to build. A README.md for usage and build instructions should also be set up.
Attachments (0)
Change History (10)
comment:1 Changed on 05/10/2016 at 12:29:08 PM by rjeschke
- Ready set
comment:2 Changed on 05/10/2016 at 12:33:02 PM by rjeschke
- Blocking 4031 added
comment:3 Changed on 05/11/2016 at 10:37:41 AM by Anton
- Owner set to Anton
comment:4 Changed on 05/12/2016 at 11:15:19 AM by asmirnov
- Owner changed from Anton to asmirnov
comment:5 Changed on 05/12/2016 at 01:46:16 PM by asmirnov
comment:6 Changed on 06/03/2016 at 01:53:56 PM by asmirnov
- Blocking 4115 added
comment:7 Changed on 06/10/2016 at 10:39:46 AM by asmirnov
- Status changed from new to reviewing
comment:9 Changed on 07/22/2016 at 12:47:15 PM by asmirnov
- Blocking 4260 added
comment:10 Changed on 10/23/2018 at 10:25:14 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
splitted into library and app. added maven module descriptor to build aar (library only)