Remove usage of non-standard function syntax

[tschuster]

Firefox has these three non-standard syntax extensions:
function f(x) x + 1;
{get() 1} {set(v) v = 1;}

[philll]

You might want to provide a bit more detail in your issues in future to enable testers to work with it.

[tschuster]

Ok, it's not clear to me what one would manually? test here. This is purely a code change that shouldn't have any observable effects. Should I just say that?

[philll]

Even if there is no direct change of functionality, it should be obvious to testers in general, which functional parts a code change belongs to such that they can verify them still working as before. That's basically, why there should be a background section in every change issue. Also, if not sufficiently obvious, a "what to change" section might make sense.

[tschuster]

Landed

​https://hg.adblockplus.org/jshydra/rev/373595f07403
​https://hg.adblockplus.org/adblockplus/rev/2d52467436ed
​https://hg.adblockplus.org/buildtools/rev/d82dea49498c
​https://hg.adblockplus.org/adblockpluschrome/rev/1e1086b0bc84

[barbaz]

With this change, latest dev builds now require at least Gecko 22, see ​https://developer.mozilla.org/docs/Web/JavaScript/Reference/arrow_functions#Browser_compatibility

[trev]

Additional commits related to unit tests:

​https://hg.adblockplus.org/adblockplustests/rev/8eaf87b44605
​https://hg.adblockplus.org/adblockpluschrome/rev/72e100e4203b

[trev]

Replying to barbaz:

With this change, latest dev builds now require at least Gecko 22, see ​https://developer.mozilla.org/docs/Web/JavaScript/Reference/arrow_functions#Browser_compatibility

Big ouch :-(

Adblock Plus 2.6.2 was already out, had to respin the release because of this - changing compatibility with this release wasn't the idea.

​https://hg.adblockplus.org/adblockplus/rev/a7ef39c39c3b - backed out this change
​https://hg.adblockplus.org/adblockplus/rev/ce3d000d9178 - relanded after the release, this time with appropriate compatibility info changes.