Opened on 08/02/2016 at 05:29:10 PM

Closed on 08/04/2016 at 10:10:34 AM

#4297 closed defect (fixed)

Regression: "filterlistsReinitialized" test parameter broken in adblockplusui

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29349006/

Description

Environment

Chrome 52.0.2743.82

How to reproduce

  1. Open first-run page.
  2. Append ?filterlistsReinitialized=true to the URL and reload page.

Expected behavior

Page contains error message explaining that filter lists had to be reinitialized.

Observed behavior

Page contains no error message.

Background

This is a regression introduced in #3719 because it changed the way the "filterlistsReinitialized" property is set when retrieving issues using the "app.get" message.

Attachments (0)

Change History (4)

comment:1 Changed on 08/02/2016 at 05:47:01 PM by greiner

  • Owner set to greiner

comment:2 Changed on 08/02/2016 at 05:47:12 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/04/2016 at 10:09:53 AM by abpbot

A commit referencing this issue has landed:
​Issue 4297 - Fixed regression: "filterlistsReinitialized" test parameter broken

comment:4 Changed on 08/04/2016 at 10:10:34 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.