Opened on 08/02/2016 at 01:10:35 PM

Closed on 10/10/2016 at 11:48:54 AM

#4296 closed change (fixed)

Update adblockplusui dependency to revision 253faf3ccf79

Reported by: greiner Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #4294
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29356364/

Description (last modified by trev)

Background

This dependency update should import the removal of the features section from the first-run page (see #4294).

Additionally, this will import #2409 and #4156 which only contain changes to the new options page and #4297 which only affects the development environment. Therefore neither of those should have an impact.

What to change

Remove imports from /skin/features/. This directory and its content no longer exist.

Attachments (0)

Change History (6)

comment:1 Changed on 08/18/2016 at 01:21:19 PM by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency from revision feea7a2cc0f5 to Update adblockplusui dependency to revision 53626d2055a6

comment:2 Changed on 10/10/2016 at 09:03:09 AM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Update adblockplusui dependency to revision 53626d2055a6 to Update adblockplusui dependency to revision 253faf3ccf79

comment:3 Changed on 10/10/2016 at 09:03:17 AM by trev

  • Owner set to trev

comment:4 Changed on 10/10/2016 at 09:08:30 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 10/10/2016 at 11:47:57 AM by abpbot

A commit referencing this issue has landed:
​Issue 4296 - Update adblockplusui dependency to revision 253faf3ccf79

comment:6 Changed on 10/10/2016 at 11:48:54 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.