Opened on 08/15/2016 at 05:45:25 PM

Closed on 08/16/2016 at 12:56:08 PM

Last modified on 10/14/2016 at 09:48:55 PM

#4335 closed defect (fixed)

Adblock Plus should forget pop-ups after the initial load

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #3568 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29349811/

Description (last modified by trev)

Environment

Adblock Plus 2.7.3.4196-beta, Firefox 51.0a1

How to reproduce

  1. Add ||ok.ru^$domain=mail.ru,popup to your Adblock Plus filters.
  2. Go to ​https://mail.ru/
  3. Click on any news link (in the middle of the page), it will open in a new tab.
  4. In that tab, click the link "Одноклассники" (fourth from left at the very top of the page).

Observed behaviour

The tab is closed. This is a regression from #3568 I think, if a window started out as a pop-up Adblock Plus for Firefox will always treat it as a pop-up - no matter how often navigation occurs.

Expected behaviour

Pop-up blocking should no longer affect navigation in this tab, it's no longer a pop-up.

Attachments (0)

Change History (6)

comment:1 Changed on 08/15/2016 at 05:46:58 PM by trev

  • Description modified (diff)
  • Priority changed from P3 to P2

comment:2 Changed on 08/15/2016 at 06:29:07 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/16/2016 at 12:55:04 PM by abpbot

A commit referencing this issue has landed:
​Issue 4335 - Adblock Plus should forget pop-ups after the initial load

comment:4 Changed on 08/16/2016 at 12:56:08 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/25/2016 at 02:12:20 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Pages that open as a popup/new tab that are then navigated in by the user are no longer still treated as popups and automatically closed.

Firefox 38 / 40 / 45 / 48 / 49(Beta) Windows 7

Last edited on 09/19/2016 at 02:04:41 AM by Ross

comment:6 Changed on 10/14/2016 at 09:48:55 PM by fanboy

This patch seemed to stop base64 popup blocking; https://issues.adblockplus.org/ticket/4368

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.