Opened on 08/19/2016 at 12:31:52 PM

Closed on 08/19/2016 at 01:23:33 PM

#4346 closed change (fixed)

Safari development build fails: "'module' object has no attribute 'get_certificates_and_key'"

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian Blocked By:
Blocking: #4340 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29349976/

Description

Background

Safari development builds are currently failing with an error message:

AttributeError: 'module' object has no attribute 'get_certificates_and_key'

This is a regression from #4340 - sitescripts are using the newest buildtools revision automatically, in this case we forgot to update them.

What to change

Make sitescripts use xarfile.get_certificates_and_key().

Attachments (0)

Change History (3)

comment:1 Changed on 08/19/2016 at 12:38:38 PM by trev

  • Review URL(s) modified (diff)

comment:2 Changed on 08/19/2016 at 01:21:59 PM by abpbot

A commit referencing this issue has landed:
​Issue 4346 - Fix exception when creating Safari builds caused by buildtools changes

comment:3 Changed on 08/19/2016 at 01:23:33 PM by trev

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.