Opened on 08/16/2016 at 07:40:09 PM

Closed on 08/17/2016 at 07:37:31 PM

Last modified on 09/22/2016 at 08:35:40 AM

#4340 closed change (fixed)

Drop dependency on external xar tool

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4346, #4452, #4459
Blocking: #4376, #4458 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29349885/

Description (last modified by trev)

Background

We currently require a ​special patched xar tool that is ​buggy and appears to be generally unmaintained. In addition, the command line interface is quite messy.

What to change

Turns out, the archive format isn't exactly complicated, so we can generate the archives ourselves from Python.

Attachments (0)

Change History (9)

comment:1 Changed on 08/16/2016 at 07:40:29 PM by trev

  • Description modified (diff)

comment:2 Changed on 08/16/2016 at 07:45:04 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/17/2016 at 07:36:48 PM by abpbot

A commit referencing this issue has landed:
​Issue 4340 - Drop dependency on external xar tool

comment:4 Changed on 08/17/2016 at 07:37:31 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/19/2016 at 12:31:52 PM by trev

  • Blocked By 4346 added

comment:6 Changed on 08/29/2016 at 10:13:17 AM by sebastian

  • Blocking 4376 added

comment:7 Changed on 09/21/2016 at 11:25:43 AM by trev

  • Blocked By 4452 added

comment:8 Changed on 09/22/2016 at 08:20:32 AM by trev

  • Blocking 4458 added

comment:9 Changed on 09/22/2016 at 08:35:40 AM by trev

  • Blocked By 4459 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.