Opened on 08/23/2016 at 08:03:43 AM
Closed on 10/12/2016 at 06:20:14 PM
Last modified on 09/09/2018 at 09:46:33 PM
#4351 closed defect (fixed)
Video ads on YouTube are not blocked using Safari 6 (Flash)
| Reported by: | rraceanu | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.12.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | kzar, rraceanu, sebastian, Ross | Blocked By: | |
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Safari 6.0 (doesn't occur on higher Safari versions)
OS X 10.8
ABP 1.21.1.1644 / 1.21.1
Easylist and AA
How to reproduce
- Open https://www.youtube.com/watch?v=0HGenoCF8Js / https://www.youtube.com/watch?v=kOkQ4T5WO9E
- Might need to navigate to other videos from the sidebar to get an ad.
Observed behaviour
Pre-roll video ad is displayed.
Expected behaviour
Video ads should be blocked.
Notes
- An exception ReferenceError: Can't find variable: History is being displayed in the console. Only when Adblock Plus is installed and only for YouTube.
- It seems likely this line in safari/include.youtube.js is to blame, and that was committed in 2014.
Attachments (0)
Change History (9)
comment:2 Changed on 08/23/2016 at 08:21:14 AM by kzar
- Cc sebastian Ross added
comment:3 Changed on 08/23/2016 at 08:52:17 AM by kzar
- Description modified (diff)
Robert has noticed there are actually exceptions being displayed, I've updated the issue. Certainly doesn't look like a recent regression in any case.
comment:4 Changed on 10/12/2016 at 03:49:37 PM by kzar
- Priority changed from Unknown to P4
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 10/12/2016 at 06:18:17 PM by abpbot
A commit referencing this issue has landed:
Issue 4351 - Check History variable exists
comment:6 Changed on 10/12/2016 at 06:20:14 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Robert please can you confirm this change fixes the problem? Since I couldn't easily reproduce the problem and the fix was so obvious I took the unusual step of pushing a fix anyway. If the problem remains for you we'll have to revert this.
comment:7 Changed on 10/24/2016 at 01:44:42 AM by rraceanu
Issue no longer occurs on 1.12.2.1670 / OS 10.8 / Safari 6 / Easylist.
comment:8 Changed on 10/24/2016 at 01:44:55 AM by rraceanu
- Verified working set
comment:9 Changed on 09/09/2018 at 09:46:33 PM by plantsower
I have ADP 1.12.4, Safari 11.1 and Sierra 10.12.6. ADP does not block any adds in YouTube. If anything it's worse. Is there a fix yet? Thanks.
This seems to be similar to #4141, but since Robert reports it also happens with 1.12.1 and that no error is displayed in the console that doesn't make sense. Perhaps our Flash YouTube blocking solution just doesn't work 100% of the time?