Update Js Shell version, replace non-standard "for each" syntax

[kzar]

Background

It would be nice to update Js Shell at some point. Unfortunately the newer versions of Js Shell (for example 45) do not support the ​non-standard and deprecated for each syntax which is used in many of the Js Hydra scripts:

astDecompile.js:10:33 SyntaxError: missing ( after for:
astDecompile.js:10:33   return [decompileAST(stmt) for each (stmt in ast.body)].join('\n');
astDecompile.js:10:33 .................................^

What to change

Update Js Shell to version 45 in utils.py:

JSSHELL_DIR = "mozilla-esr45"
JSSHELL_URL = ("https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly"
               "/2016/05/2016-05-29-00-15-03-%s/jsshell-%%s.zip" % JSSHELL_DIR)

Replace any non standard "for each" syntax used by the Js Hydra scripts with standard JavaScript.

[kzar]

Even modern versions of Js Shell do not support the for (const foo of bar) syntax, so I will have to instead modify punycode.js.

[trev]

For reference, this is ​bug 1101653.

[sebastian]

I thought we removed all for each loops with #301. If we missed some code there, or regressed since then, we should fix that. Feel free to update the issue description to exclude the jsshell update.

[kzar]

Alright then, since I've done most of it already I'll finish it off and upload a review.

[trev]

Strictly speaking, JSHydra isn't our code (particularly astDecompile.js that this is about) - which is why we didn't touch it yet. At some point we won't be able to avoid it any more however so we need to remove the for each loops there as well.

[kzar]

So far I've just posted a review for removing for each. Updating JS Shell to version 45 required further changes to adblockpluschrome, adblockpluscore and jshdyra. I still haven't got it quite working!

[kzar]

I'm stuck for now with Js Shell 45, getting this message when adblockpluscore/lib/filterClasses.js is included:

uncaught exception: Unknown kind undefined
(Unable to print stack trace)

[kzar]

(Posting a review for my changes to update Js Shell in case any of you guys fancy trying to get it to work!)

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Remove non standard and unused code

[kzar]

OK apparently it's the __proto__ syntax inside filterClasses.js that it's complaining about. Stuff like this:

RegExpFilter.prototype =
{
  __proto__: ActiveFilter.prototype,
  ...
};

Changing it to use Object.create seems to help, shame it's more verbose:

RegExpFilter.prototype = Object.create(ActiveFilter.prototype, {
  ...
};

Will post a review to change all those when I get a chance.

[kzar]

Yep, once I replaced {__proto__: ...} with Object.create(...) everywhere in adblockpluscore and adblockplustests I finally got adblockpluschrome to build using Js Shell 45!

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Remove deprecated __proto__ syntax

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Remove deprecated __proto__ syntax

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Avoid redeclaring images parameter

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Update Js Shell to version 45

[abpbot]

A commit referencing this issue has landed:
​Issue 4353 - Update jshydra dependency