Opened on 08/28/2016 at 07:36:26 PM

Closed on 08/30/2016 at 01:50:27 PM

#4374 closed change (fixed)

Make the Python code that is part of jsHydra comply to our coding practices

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4373
Blocking: #4375 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29350244

Description (last modified by sebastian)

Background

In #4373 we started to clean up the Python code of jsHydra, added a tox.ini and support for Python 3. However, as opposed to most of our Python code, we don't run flake8 there yet. And during the port to Python 3, it turned out that there are still a few quality issues with that code.

What to change

Make the tox.ini in the ​jshydra repository run flake8 with the pep8-naming and flake8-abp, and fix any reported issue.

Attachments (0)

Change History (4)

comment:1 Changed on 08/28/2016 at 07:40:30 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/29/2016 at 09:20:14 AM by sebastian

  • Blocking 4375 added

comment:3 Changed on 08/30/2016 at 01:48:29 PM by abpbot

A commit referencing this issue has landed:
​Issue 4374 - Made Python code comply with our coding practices and added flake8

comment:4 Changed on 08/30/2016 at 01:50:27 PM by sebastian

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.