Opened on 08/29/2016 at 09:20:14 AM
Closed on 08/31/2016 at 08:46:52 AM
#4375 closed change (fixed)
Update dependency from buildtools on jshydra for Python 3 support
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | Blocked By: | #4373, #4374 | |
Blocking: | #4047, #4376 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by kzar)
Background
With #4373 Python 3 support has been added to jshydra. Further improvements under the hood have been implemented with #4374. (In #4353 we have also removed some non-standard and unused JavaScript code.) So before we can port buildtools to Python 3, we have to update jshydra.
What to change
- Update the dependencies file to refer to the revisions that include the mentioned changes.
- Adapt for API changes: doRewrite(files, args) from jshydra.abp_rewrite has been renamed to rewrite_js(args) where args refers to the raw arguments passed to jshydra now.
Attachments (0)
Change History (6)
comment:1 Changed on 08/29/2016 at 09:23:32 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/29/2016 at 09:27:04 AM by sebastian
- Blocking 4047 added
comment:3 Changed on 08/29/2016 at 10:13:17 AM by sebastian
- Blocking 4376 added
comment:5 Changed on 08/31/2016 at 08:44:47 AM by abpbot
comment:6 Changed on 08/31/2016 at 08:46:52 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4375 - Updated jshydra dependency for Python 3 support