Opened on 09/12/2016 at 05:47:20 PM
Closed on 01/26/2019 at 03:27:37 AM
#4413 closed change (fixed)
Merge formmail.py and formmail2.py
| Reported by: | kvas | Assignee: | rhowell |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | kvas | Blocked By: | #4377, #4421, #4422, #4423, #4424 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kvas)
Background
We've developed a configurable form to email service for Acceptable Ads website (#4377). It's now possible to implement the functionality of formmail.py via configuring formmail2.py in a specific way, so we can do that, eliminate formmail.py and rename formmail2.py to formmail.py (taking care of the relevant configuration changes).
What to change
Here's the outline of the migration path that we'll need to take (detailed configuration snippets to be added):
- Migrate eyeo.com to "formmail2": #4421.
- Replace the old implementation of "formmail" with "formmail2" and add an alias: #4422.
- Migrate eyeo.com and acceptableads.org to use "formmail": #4423.
- Remove the alias: #4424.
- Document the configuration and usage of formmail to facilitate future reuse. Add README.md to sitescripts/formmail with the explanation aimed at a person configuring the server. Add comments and docstrings to formmail.py as appropriate. This can be done separately or as part of steps 2 or 4.
Attachments (0)
Change History (13)
comment:2 Changed on 09/13/2016 at 05:30:31 PM by kvas
- Blocked By 4421 added
comment:4 Changed on 09/13/2016 at 05:36:21 PM by kvas
- Blocked By 4422 added
comment:5 Changed on 09/13/2016 at 05:41:33 PM by kvas
- Blocked By 4423 added
comment:6 Changed on 09/13/2016 at 05:45:02 PM by kvas
- Blocked By 4424 added
comment:8 Changed on 09/14/2016 at 10:25:01 AM by kvas
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:9 Changed on 01/17/2019 at 08:34:58 AM by rhowell
- Cc kvas added
- Owner set to rhowell
comment:10 Changed on 01/17/2019 at 08:35:19 AM by rhowell
Last edited on 01/17/2019 at 08:47:21 PM
by rhowell
comment:11 Changed on 01/17/2019 at 08:42:57 AM by rhowell
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:12 Changed on 01/26/2019 at 01:45:13 AM by abpbot
A commit referencing this issue has landed:
Issue 4413 - Merge formmail.py and formmail2.py
comment:13 Changed on 01/26/2019 at 03:27:37 AM by rhowell
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Since web.eyeo.com is no longer in use, and therefore formmail.py is no longer in use, maybe it makes sense to update this ticket. I'd suggest closing 4421-4424, and just using this issue to track the changes.