Opened on 09/13/2016 at 05:36:21 PM
Closed on 01/17/2019 at 09:18:34 PM
#4422 closed change (duplicate)
Replace the old implementation of "formmail" with "formmail2" and add an alias
Reported by: | kvas | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Sitescripts | Keywords: | goodfirstbug |
Cc: | Blocked By: | #4421 | |
Blocking: | #4413, #4423 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by kvas)
Background
See #4413. This is the second step that should only be pushed after #4421 is deployed.
What to change
- Replace the content of formmail.py with the content of formmail2.py.
- Make formmail configuration process use [formmail] section of the configuration and fall back to [formmail2] if that is not present.
- Replace the content of formmail2.py with from . import formmail.
- Delete eyeo.mail from sitescripts/formmail/template.
- Remove formmail tests, put formmail tests into test_formmail.py and adjust them to import formmail instead of formmail2.
Attachments (0)
Change History (7)
comment:2 Changed on 09/13/2016 at 05:41:33 PM by kvas
- Blocking 4423 added
comment:4 Changed on 09/14/2016 at 10:25:44 AM by kvas
- Priority changed from Unknown to P3
- Ready set
comment:5 Changed on 11/25/2016 at 03:22:23 PM by sebastian
- Keywords goodfirstbug added
comment:6 Changed on 01/17/2019 at 09:18:16 PM by rhowell
comment:7 Changed on 01/17/2019 at 09:18:34 PM by rhowell
- Resolution set to duplicate
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Since we stopped using web.eyeo.com, this change has become much less complicated. Closing this ticket; the change will be tracked in #4413.