Opened on 09/21/2016 at 11:25:43 AM

Closed on 09/22/2016 at 08:05:43 AM

Last modified on 09/22/2016 at 08:20:32 AM

#4452 closed defect (fixed)

updateUpdateManifests script errors out failing to import get_certificates_and_key

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian Blocked By:
Blocking: #4340, #4458 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29354340/

Description

Background

python -m sitescripts.extensions.bin.updateUpdateManifests currently fails:

  File "/opt/sitescripts/sitescripts/extensions/bin/updateUpdateManifests.py", line 30, in <module>
    from buildtools.packagerSafari import (get_developer_identifier,
ImportError: cannot import name get_certificates_and_key

This is a regression from #4340 and merely went unnoticed so far because the corresponding process on the update server was hanging.

What to change

Update updateUpdateManifests script to use xarfile.read_certificates_and_key().

Attachments (0)

Change History (4)

comment:1 Changed on 09/21/2016 at 11:33:11 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/22/2016 at 08:05:01 AM by abpbot

comment:3 Changed on 09/22/2016 at 08:05:43 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 09/22/2016 at 08:20:32 AM by trev

  • Blocking 4458 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.