Opened on 09/22/2016 at 08:35:40 AM
Closed on 09/22/2016 at 12:51:45 PM
#4459 closed change (rejected)
xarfile should not expect Crypto.Signature module to be present
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | #4340 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
As of #4458 we are now using PyCrypto on the update server. However, it turned out that Ubuntu Precise gets the outdated PyCrypto 2.4.1 version which doesn't have Crypto.Signature module. So updating manifests fails because buildtools.xarfile cannot be imported.
What to change
Crypto.Signature module is only necessary for the buildtools.xarfile.get_signature method. Update server doesn't call this method, it merely needs to decode the certificates. So we can move the import into this method rather than have it at top level.
Attachments (0)
Change History (5)
comment:1 Changed on 09/22/2016 at 10:24:56 AM by abpbot
comment:2 Changed on 09/22/2016 at 10:25:39 AM by trev
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 09/22/2016 at 10:25:51 AM by trev
- Component changed from Sitescripts to Build-and-Release-Tools
comment:4 Changed on 09/22/2016 at 12:50:37 PM by trev
- Resolution fixed deleted
- Status changed from closed to reopened
Rolled back in https://hg.adblockplus.org/buildtools/rev/6657d71cdccc, this isn't sufficient to support PyCrypto 2.4 on the server so we need to get a newer version there.
comment:5 Changed on 09/22/2016 at 12:51:45 PM by trev
- Resolution set to rejected
- Status changed from reopened to closed
A commit referencing this issue has landed:
Issue 4459 - xarfile should not expect Crypto.Signature module to be present