Opened on 09/22/2016 at 06:09:41 PM
Closed on 09/25/2016 at 01:34:01 PM
Last modified on 10/25/2016 at 04:35:47 AM
#4466 closed change (fixed)
Update adblockpluscore dependency, replace rsa.js with rsa module
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | #4465 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
In #4465 we are migrating rsa.js into adblockpluscore and turning it into a proper module. We now need to remove rsa.js from adblockpluschrome and adapt our code to use that module.
What to change
- Update the buildtools dependency to hg:595808987fd9 git:5f8a4c2. (Also includes a change which was immediately backed out.)
- Update the adblockpluscore dependency to hg:d451a8ff84b9 git:56fcfd1. (Does not include any other changes.)
- Delete adblockpluschrome/lib/rsa.js, adblockpluschrome/lib/jsbn.js, adblockpluschrome/lib/sha1.js.
- Delete qunit/tests/signatures.js.
- Modify metadata.common to include adblockpluscore/lib/rsa.js, adblockpluscore/lib/jsbn.js and adblockpluscore/lib/rusha.js.
- Modify metadata.common to remove lib/sha1.js , lib/jsbn.js and lib/sha1.js from background and test scripts.
- Modify lib/whitelisting.js to import verifySignature function from the rsa module.
Hints for testers
Make sure that sitekey based whitelisting still works for Chrome, Opera and Safari. (For an example page you can try https://sitekey.kzar.co.uk .)
Attachments (0)
Change History (8)
comment:4 Changed on 09/23/2016 at 12:46:20 PM by kzar
comment:6 Changed on 09/25/2016 at 01:32:28 PM by abpbot
A commit referencing this issue has landed:
Issue 4466 - Remove rsa.js, update core + buildtools
comment:7 Changed on 09/25/2016 at 01:34:01 PM by kzar
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/25/2016 at 04:35:47 AM by rraceanu
- Verified working set
Verified and sitekey whitelisting works on ABP version 1.12.2.1670, Chrome 45, 51, 54, Opera 35, 40 and Safari 8
Note: See
TracTickets for help on using
tickets.
I changed the description to include jsbn.js and rusha.js, also added a note on removing tests - these should be moved to adblockpluscore in #4465.