#4467 closed defect (fixed)

Js Hydra converting some hex strings incorrectly

Reported by:	kzar	Assignee:	trev
Priority:	P3	Milestone:
Module:	Automation	Keywords:	jshydra
Cc:	trev, sebastian	Blocked By:
Blocking:	#4465, #4468	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29354754/

64 bit Linux, JS Shell 45

Create a file called jsshell/test.js with the following contents:
```
"\x2B\x0E\x03\x02\x1A";
```
Run this command: mozilla-esr45-linux-x86_64/js jshydra.js scripts/abprewrite.js test.js | grep '"' (ensuring the js shell path is correct).

Output is: "+\x014\x03\x02\x110";

Output should be "+\x0E\x03\x02\x1A";.

Function sanitize() in scripts/astDecompile.js forgets to hex-encode numbers - so instead of A you get 10 in the string literal.

Summary:
Description:	You may use WikiFormatting here. === Environment === 64 bit Linux, JS Shell 45 === How to reproduce === 1. Create a file called jsshell/test.js with the following contents: {{{ "\x2B\x0E\x03\x02\x1A"; }}} 2. Run this command: `mozilla-esr45-linux-x86_64/js jshydra.js scripts/abprewrite.js test.js \| grep '"'` (ensuring the js shell path is correct). === Observed behaviour === Output is: `"+\x014\x03\x02\x110";` === Expected behaviour === Output should be `"+\x0E\x03\x02\x1A";`. === Background === Function `sanitize()` in `scripts/astDecompile.js` forgets to hex-encode numbers - so instead of `A` you get `10` in the string literal.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29354754/