Opened on 10/04/2016 at 04:06:48 PM

Closed on 08/15/2017 at 03:37:02 PM

#4491 closed change (fixed)

Prevent page front matter from breaking formatting and linting

Reported by: juliandoucette Assignee: jsonesen
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, saroyanm, fhd, trev, sebastian Blocked By:
Blocking: #4488 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29512597/

Description (last modified by juliandoucette)

Background

Our CMS supports page front matter. Although this is effective, it is inconvenient because it messes with formatting, linting, and/or preview in some code and markdown editors.

What to change

Allow page front matter to be surrounded by HTML comments. EG:

<!--
title = Awesome page
description = Awesome description
-->

Attachments (0)

Change History (11)

comment:1 Changed on 10/04/2016 at 04:08:55 PM by juliandoucette

  • Summary changed from Support HTML comments around front matter in CMS to Prevent page front matter from breaking formatting and linting

comment:2 Changed on 10/04/2016 at 04:39:20 PM by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed on 10/04/2016 at 06:51:45 PM by juliandoucette

  • Description modified (diff)

comment:4 Changed on 10/04/2016 at 07:07:33 PM by juliandoucette

  • Description modified (diff)

comment:5 Changed on 03/20/2017 at 10:25:19 AM by jsonesen

  • Owner set to jsonesen

comment:6 Changed on 07/18/2017 at 01:33:23 PM by juliandoucette

Can we bump this to P3 please?

comment:7 Changed on 07/21/2017 at 05:38:13 PM by kvas

  • Priority changed from P4 to P3

comment:8 Changed on 08/10/2017 at 06:20:16 PM by jsonesen

  • Blocking 4488 added

comment:9 Changed on 08/11/2017 at 08:39:22 AM by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed on 08/15/2017 at 11:00:17 AM by abpbot

A commit referencing this issue has landed:
​Issue 4491 - Adds handling for block commented page front matter

comment:11 Changed on 08/15/2017 at 03:37:02 PM by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jsonesen.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.