Opened on 10/06/2016 at 12:13:32 PM
Closed on 10/07/2016 at 06:35:09 PM
#4497 closed change (fixed)
Move Utils.getRequestWindow() into child/utils.js
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We are currently exposing the functionality to retrieve the DOM window responsible for a request as Utils.getRequestWindow(). This has historical reasons - as we are only dealing with requests and DOM windows in the child process, this functionality is misplaced now.
What to change
Expose getRequestWindow() as an exported function of child/utils.js.
Attachments (0)
Change History (3)
comment:1 Changed on 10/06/2016 at 12:18:54 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/07/2016 at 06:09:14 PM by abpbot
comment:3 Changed on 10/07/2016 at 06:35:09 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4497 - Move Utils.getRequestWindow() into child/utils.js