Opened on 10/07/2016 at 07:58:03 AM

Closed on 10/07/2016 at 10:54:07 AM

#4500 closed defect (fixed)

Element hiding integration tests broken

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #521 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29356283/

Description

How to reproduce

  1. Install Adblock Plus Tests extension from adblockplustests repository.
  2. Go to extension preferences, choose "elemhide" and click Run.

Observed behaviour

All tests fail because ElemHide.apply() no longer exists as of #521.

Expected behaviour

Tests should pass.

What to change

This test should not mess with the internals of ElemHide, it should rather add the necessary filters to FilterStorage. Also, the asynchronous behavior of ElemHide is gone as of #521 so loading the frame immediately after adding the filters is fine.

Attachments (0)

Change History (3)

comment:1 Changed on 10/07/2016 at 09:16:31 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/07/2016 at 10:53:44 AM by abpbot

A commit referencing this issue has landed:
​Issue 4500 - Fix element hiding integration tests

comment:3 Changed on 10/07/2016 at 10:54:07 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.