Opened on 10/07/2016 at 10:09:34 AM

Closed on 10/07/2016 at 10:43:49 AM

#4501 closed defect (fixed)

Filters with key 0 stay "unconditional" even after an exception is added

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4450 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29356322/

Description

How to reproduce

  1. With a completely empty filter list, add ##test and then example.com#@#test.
  2. Open example.com.

Observed behaviour

The filter ##test still applies on example.com. The code which should mark it as no more unconditional fails because its filter key is 0.

Expected behaviour

The filter ##test should no longer apply.

Attachments (0)

Change History (3)

comment:1 Changed on 10/07/2016 at 10:12:37 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/07/2016 at 10:41:45 AM by abpbot

A commit referencing this issue has landed:
​Issue 4501 - Fix treatment of element hiding filters with filter key 0

comment:3 Changed on 10/07/2016 at 10:43:49 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.