Opened on 10/07/2016 at 11:24:49 AM

Closed on 10/07/2016 at 12:41:18 PM

#4504 closed change (fixed)

Speed up element hiding integration tests

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29356338/

Description

Background

Element hiding integration tests take considerable time right now because of running each check four times: once with no extra filters, once with a document exception rule, once with an invalid document exception rule and once with an element hiding exception rule.

What to change

Have extra tests for the exception rules, like we have them for $generichide already - do not repeat all tests with the exception rules.

Attachments (0)

Change History (3)

comment:1 Changed on 10/07/2016 at 11:26:11 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/07/2016 at 12:40:42 PM by abpbot

A commit referencing this issue has landed:
​Issue 4504 - Speed up element hiding integration tests

comment:3 Changed on 10/07/2016 at 12:41:18 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.