Opened on 10/07/2016 at 10:12:33 PM

Closed on 01/11/2017 at 05:38:12 PM

Last modified on 05/12/2017 at 10:14:29 AM

#4505 closed change (fixed)

Add translations

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu, Shikitita Blocked By: #4602, #4648
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29370727/

Description (last modified by diegocarloslima)

Background

Currently, we only support English.

What to change

Add alternative string resources to provide support to the following languages: Spanish, Polish, Korean, Portuguese, Turkish, German, Greek, Russian, French, Italian and Dutch . The translations should follow the attached translation file.

Attachments (1)

SBrowser_Strings_all translations_Final.xls (64.5 KB) - added by diegocarloslima on 01/03/2017 at 06:16:16 PM.

Download all attachments as: .zip

Change History (10)

comment:1 Changed on 11/04/2016 at 03:27:29 PM by diegocarloslima

  • Priority changed from Unknown to P2

comment:2 Changed on 11/04/2016 at 04:01:29 PM by diegocarloslima

  • Blocked By 4602 added

comment:3 Changed on 12/16/2016 at 10:44:07 AM by diegocarloslima

  • Blocked By 4648 added

comment:4 Changed on 01/03/2017 at 06:14:26 PM by diegocarloslima

  • Description modified (diff)

Changed on 01/03/2017 at 06:16:16 PM by diegocarloslima

comment:5 Changed on 01/03/2017 at 06:17:03 PM by diegocarloslima

  • Owner set to diegocarloslima
  • Ready set

comment:6 Changed on 01/04/2017 at 05:28:55 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 01/11/2017 at 05:31:20 PM by abpbot

A commit referencing this issue has landed:
Issue 4505 - Add translations

comment:8 Changed on 01/11/2017 at 05:38:12 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 05/12/2017 at 10:14:29 AM by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The following languages properly apply to ABP Samsung Internet when the device language is set to the desired language before app installation (As Designed).

Spanish - ok
Polish - ok
Korean - ok
Portuguese - ok
Turkish - ok
German - ok
Greek - ok
Russian - ok
French - ok
Italian - ok
Dutch - ok

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
 
Note: See TracTickets for help on using tickets.