Opened on 10/18/2016 at 09:00:33 AM
Closed on 10/19/2016 at 12:37:43 PM
#4546 closed defect (worksforme)
Sbrowser is not opened from ABP after Sbrowser update
Reported by: | scheer | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
Cc: | diegocarloslima, vickyyu | Blocked By: | |
Blocking: | Platform: | Samsung Browser | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
As shown in #3995 the user is presented with a message asking them to update to Samsung Internet 4.0 and higher to be able to use ABP for SBrowser.
Currently, after upgrading, opening and then completing the first run screen of Sbrowser, the user should be able to re-launch ABP and then select'Configure Samsung Browser settings' and be taken directly to the option of enabling the Blocking Functionality within Sbrowser itself.
However, when the user currently selects 'Configure Samsung Browser settings', ABP blinks and remains on the setting screen and Sbrowser is not opened.
Environment
ABP for Sbrowser 1.0.4
Galaxy S4
Android 5.0.1
How to reproduce
- Have Sbrowser 4.0 or lower installed
- Install ABP 1.0.4
- Select 'Get update'
- Select 'Update'
- Select 'Open'
- Go past first run screens
- Open ABP and select 'Got it'
- Select 'Configure Samsung Browser settings'
Observed behaviour
Samsung Browser is not opened and the user remains on the ABP settings screen.
Expected behaviour
User is directed to the settings page and is able to enable ABP in the Content Blockers section.
Attachments (1)
Change History (3)
Changed on 10/18/2016 at 09:01:03 AM by scheer
comment:1 Changed on 10/18/2016 at 01:07:45 PM by diegocarloslima
comment:2 Changed on 10/19/2016 at 12:37:43 PM by scheer
- Resolution set to worksforme
- Status changed from new to closed
Trying it out on a real Galaxy S4, Android 5.0.1, the process works. It could well be that Test Object resigning caused some issues here.
Because of the above, I will close this issue.
It looks like it's an issue with the APK signing, the Samsung Internet app queries for a list of approved signatures and compares with the one in the APK and only if it matches that it accepts the 'Configure Samsung Browser Settings' call. TestObject may have changed the signature of the APK, making it behave like that.