Opened on 10/19/2016 at 10:07:06 AM
Closed on 10/27/2016 at 04:06:22 PM
Last modified on 10/27/2016 at 04:11:05 PM
#4548 closed change (fixed)
Adapt release automation for Safari and Edge
| Reported by: | sebastian | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | kzar, kvas, jsonesen, trev | Blocked By: | |
| Blocking: | #4551, #4581 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
Currently, build.py release -t chrome will generate release builds for Chrome and Safari. However, we want to release for Chrome and Safari separately from now on, with Adblock Plus for Safari being released out of a bookmark.
Release builds for Microsoft Edge are currently manually created, out of a separate repository. In the next step, we want to move Edge support into a bookmark in adblockpluschrome and use the release automation (see #4028).
(For the related sitescripts changes, for the development builds, see #4540.)
What to change
- Implement build.py release -t safari|edge, generating release builds for Safari and Microsoft Edge respectively.
- Change build.py release -t chrome, so that it doesn't create a Safari build anymore.
Attachments (0)
Change History (8)
comment:1 Changed on 10/19/2016 at 10:16:58 AM by kzar
- Cc trev added
- Description modified (diff)
- Owner set to kzar
comment:4 Changed on 10/19/2016 at 11:45:56 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 10/19/2016 at 06:51:51 PM by kzar
- Blocking 4551 added
comment:6 Changed on 10/27/2016 at 04:03:47 PM by abpbot
A commit referencing this issue has landed:
Issue 4548 - Split out Safari and add Edge release automation
comment:7 Changed on 10/27/2016 at 04:06:22 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/27/2016 at 04:11:05 PM by kzar
- Blocking 4581 added
Release automation doesn't care about revisions, it always uses the current repository state. So bookmarks are irrelevant here, I removed this requirement from "what to change."