Opened on 10/25/2016 at 01:01:13 PM
Closed on 07/05/2017 at 08:52:42 AM
#4566 closed change (fixed)
Remove crashreporter check from adblockbrowser-build/build.py
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | #2490 | |
| Blocking: | #3768, #4677 | Platform: | Adblock Browser for Android |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Background
Since crashreporter will be disabled without the need of adding --disable-crashreporter to mozconfig, we don't need to check for it on build.py anymore
What to change
Remove --disable-crashreporter check from build.py
Hints for Testers
Similarly to #2490 , this can be verified as disabled by checking if MOZ_CRASHREPORTER = false in AppConstants.java after building the project. It should always be false, no matter the mozconfig configuration
Attachments (0)
Change History (8)
comment:1 Changed on 10/25/2016 at 02:25:19 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/30/2016 at 01:54:52 PM by diegocarloslima
- Blocking 4677 added
comment:3 Changed on 12/12/2016 at 11:24:34 AM by abpbot
comment:4 Changed on 12/12/2016 at 11:26:05 AM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/28/2016 at 06:24:19 PM by diegocarloslima
- Blocking 3768 added
comment:6 Changed on 06/20/2017 at 09:15:31 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
Is there any hints for testers or way for me to check such a change?
comment:8 Changed on 07/05/2017 at 08:52:42 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- MOZ_CRASHREPORTER = false in AppConstants.java.
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4566 - Remove crashreporter check from adblockbrowser-build/build.py