Opened on 05/11/2015 at 12:05:03 PM
Closed on 07/05/2017 at 08:46:21 AM
#2490 closed change (fixed)
Investigate another way to disable the crash reporter
| Reported by: | rjeschke | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | fhd | Blocked By: | #2478 |
| Blocking: | #3767, #4566, #4567 | Platform: | Adblock Browser for Android |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
As we currently do not want to have Firefox' crash reporter enabled, we disable it completely with a build configuration switch.
Investigate if there is another clean way to disable the crash reporter without having the developer add ac_add_options --disable-crashreporter in mozconfig file.
Hints for Testers
The crash reporter can be verified as disabled by checking if MOZ_CRASHREPORTER = false in AppConstants.java after building the project. It should always be false, no matter the mozconfig configuration:
1) For a mozconfig file with ac_add_options --disable-crashreporter config option
2) For a mozconfig file with ac_add_options --enable-crashreporter config option
3) For a mozconfig file with none of the above config options
Attachments (0)
Change History (15)
comment:1 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:2 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
comment:3 Changed on 05/24/2016 at 08:25:09 AM by diegocarloslima
- Owner set to diegocarloslima
- Tester set to Unknown
comment:4 Changed on 05/24/2016 at 04:01:16 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 10/20/2016 at 09:30:52 AM by diegocarloslima
- Blocking 3767 added
comment:6 Changed on 10/25/2016 at 01:01:13 PM by diegocarloslima
- Blocking 4566 added
comment:7 Changed on 10/25/2016 at 01:06:50 PM by diegocarloslima
- Blocking 4567 added
comment:8 Changed on 10/25/2016 at 03:39:21 PM by abpbot
A commit referencing this issue has landed:
Issue 2490 - Investigate another way to disable the crash reporter
comment:9 Changed on 10/25/2016 at 03:40:59 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 06/19/2017 at 07:36:00 AM by scheer
- Cc fhd added
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
What was the change here exactly if any at all? Could you please add some description of the change and hints for testers?
Thanks
comment:11 Changed on 06/30/2017 at 02:15:04 PM by diegocarloslima
- Description modified (diff)
comment:12 Changed on 06/30/2017 at 02:24:16 PM by diegocarloslima
The change was made in configure.in file to make sure that MOZ_CRASHREPORTER will always be set to false, independently of the configuration in mozconfig file. I have updated the description with more info
comment:13 Changed on 06/30/2017 at 02:28:56 PM by diegocarloslima
- Description modified (diff)
comment:14 Changed on 06/30/2017 at 02:37:43 PM by diegocarloslima
- Description modified (diff)
comment:15 Changed on 07/05/2017 at 08:46:21 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- MOZ_CRASHREPORTER = false in AppConstants.java.
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
See #2673