Opened on 10/27/2016 at 03:46:11 PM
Closed on 08/29/2019 at 05:43:18 PM
#4580 closed change (rejected)
Remove the remaining ext code
| Reported by: | kzar | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sebastian, mjethani, greiner | Blocked By: | #4551, #4579 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29569649 |
||
Description
Background
For issue 4551 we are looking to remove the Safari code. Then in issue 4579 we are targeting the browserext API consistently, with only a small pollyfill for Chrome.
The next thing we want to do is to remove or migrate any remaining ext platform code that hasn't already been removed.
What to change
- Replace the PageMap class and all instances with a single Map.
- Move any ext code that is still required (apart from the Chrome browserext pollyfill) out of ext.
Attachments (0)
Change History (21)
comment:1 Changed on 10/27/2016 at 03:55:32 PM by kzar
- Blocked By 4551 added
comment:2 Changed on 05/29/2017 at 03:55:36 PM by kzar
- Cc mjethani added
comment:3 Changed on 10/10/2017 at 12:53:11 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Replace ext.i18n.getMessage with i18n.getMessage
comment:4 Changed on 10/10/2017 at 12:54:54 PM by greiner
- Cc greiner added
comment:5 Changed on 10/10/2017 at 01:04:00 PM by mjethani
- Owner set to mjethani
comment:6 Changed on 10/10/2017 at 05:28:48 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Replace ext.i18n with i18n
comment:7 Changed on 10/11/2017 at 04:45:18 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage
comment:8 Changed on 10/12/2017 at 07:59:52 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Remove ext.backgroundPage.getWindow
comment:9 Changed on 10/12/2017 at 08:02:22 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Replace ext.getURL with extension.getURL
comment:10 Changed on 10/13/2017 at 07:52:44 PM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Replace ext.backgroundPage.sendMessage with runtime.sendMessage
comment:11 Changed on 01/05/2018 at 02:31:33 PM by tschuster
I am going to work on remove at least ext.webRequest, but I will try to get more done.
comment:12 Changed on 03/30/2018 at 11:19:46 PM by sebastian
- Review URL(s) modified (diff)
comment:13 Changed on 03/31/2018 at 01:19:22 AM by sebastian
- Review URL(s) modified (diff)
comment:14 Changed on 03/31/2018 at 06:52:31 AM by mjethani
- Review URL(s) modified (diff)
comment:15 Changed on 04/05/2018 at 06:32:02 PM by abpbot
Some commits referencing this issue have landed:
comment:16 Changed on 04/14/2018 at 12:18:36 PM by sebastian
- Review URL(s) modified (diff)
comment:17 Changed on 04/16/2018 at 11:09:39 AM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Removed ext.webRequest.handlerBehaviorChanged()
comment:18 Changed on 04/24/2018 at 05:18:54 PM by sebastian
- Review URL(s) modified (diff)
comment:19 Changed on 04/25/2018 at 11:41:09 AM by abpbot
A commit referencing this issue has landed:
Issue 4580 - Removed ext.storage
comment:20 Changed on 05/23/2019 at 09:22:23 PM by sebastian
- Owner mjethani deleted
comment:21 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
FYI I think this is the issue that Sebastian was referring to recently Manish. I guess we should tweak it though, since we're no longer planning to do the changes in #4579 in the immediate future.