Opened on 11/04/2016 at 02:32:40 PM

Closed on 01/04/2017 at 03:02:21 PM

Last modified on 05/09/2017 at 10:15:25 AM

#4602 closed change (fixed)

Change 'Samsung Browser' wording to 'Samsung Internet'

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu, Shikitita, lisabielik Blocked By:
Blocking: #4505 Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29361733

Description

Background

In order to keep consistency with Samsung's terminology and naming conventions and also across our translations, we should use 'Samsung Internet' in the place of 'Samsung Browser'.

What to change

Replace occurrences of 'Samsung Browser' by 'Samsung Internet' in app strings

Attachments (0)

Change History (4)

comment:1 Changed on 11/04/2016 at 04:01:29 PM by diegocarloslima

  • Blocking 4505 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/04/2017 at 03:01:53 PM by abpbot

comment:3 Changed on 01/04/2017 at 03:02:21 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 05/09/2017 at 10:15:25 AM by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • 'Samsung Internet' now correctly displays across the app and in the content blocking screen of Samsung Internet itself.

adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0

adblockplussbrowser-release-signed-1
Galaxy S4
Android 5.0.1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
 
Note: See TracTickets for help on using tickets.