Opened on 11/07/2016 at 11:26:39 AM
Closed on 11/07/2016 at 02:21:50 PM
#4608 closed defect (fixed)
Development build for Safari created from master bookmark
| Reported by: | kzar | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | jsonesen, trev, sebastian, kvas | Blocked By: | |
| Blocking: | #4551 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
How to reproduce
Push a commit to the master bookmark of adblockpluschrome, leaving the safari bookmark alone.
Observed behaviour
The createNightlies scripts attempt to create a development build for Safari as well as Chrome and Opera.
Expected behaviour
Only Chrome and Opera builds should be created.
Analysis
There is a bug in the Configuration object, the revision property is defined as global - meaning common for all build configurations. Since there is no such global setting its value always defaults to "master".
What to change
The property needs to be defined with local=True parameter.
Attachments (0)
Change History (11)
comment:1 Changed on 11/07/2016 at 12:47:32 PM by kzar
- Owner set to kzar
comment:2 Changed on 11/07/2016 at 01:03:28 PM by kzar
- Owner kzar deleted
comment:3 Changed on 11/07/2016 at 01:15:11 PM by trev
comment:7 Changed on 11/07/2016 at 01:36:20 PM by trev
- Owner set to jsonesen
comment:8 Changed on 11/07/2016 at 01:37:20 PM by trev
- Status changed from new to reviewing
comment:9 Changed on 11/07/2016 at 01:41:45 PM by sebastian
- Ready set
comment:10 Changed on 11/07/2016 at 01:52:13 PM by abpbot
A commit referencing this issue has landed:
Issue 4608 - Add local=True To Revision Property
comment:11 Changed on 11/07/2016 at 02:21:50 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
It seems that the configuration setting wasn't picked up for some reason, the Configuration object still gives me "master" even for Safari.