Opened on 11/07/2016 at 11:43:37 AM
Closed on 11/07/2016 at 02:21:55 PM
#4610 closed defect (fixed)
Safari development builds are failing
| Reported by: | kzar | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | trev, sebastian, kvas | Blocked By: | |
| Blocking: | #4551 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
How to reproduce
Update you local copy of the adblockpluschrome repository to master bookmark and try creating a Safari build:
./build.py -t safari build -k adblockplussafari.pem
Observed behaviour
The development build fails to be generated:
jinja2.exceptions.TemplateNotFound: xartoc.xml.tmpl
Expected behaviour
The build is generated successfully.
Background
This is a regression from #4028. All templates moved into templates/ directory there yet xartoc.xml.tmpl was forgotten for some reason - yet packager.getTemplate() is used to load this template and it looks in the templates/ directory now.
Attachments (0)
Change History (5)
comment:1 Changed on 11/07/2016 at 02:12:13 PM by trev
- Cc kvas added
- Description modified (diff)
- Owner set to trev
comment:2 Changed on 11/07/2016 at 02:15:07 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/07/2016 at 02:15:55 PM by kvas
- Ready set
comment:4 Changed on 11/07/2016 at 02:20:23 PM by abpbot
comment:5 Changed on 11/07/2016 at 02:21:55 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4610 - Fixed Safari builds, broken by https://hg.adblockplus.org/buildtools/rev/1e56a7549872