Opened on 11/07/2016 at 04:26:53 PM
Closed on 08/24/2017 at 11:33:44 AM
Last modified on 09/20/2017 at 08:53:43 AM
#4616 closed change (fixed)
Push Edge related changes to the edge bookmark of adblockpluschrome
| Reported by: | kzar | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | oleksandr, sebastian, jsonesen | Blocked By: | |
| Blocking: | #4617 | Platform: | Edge |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Now that #4540 and #4028 are taken care of we are ready to start adding Microsoft Edge support to adblockpluschrome under the edge bookmark.
What to change
In order:
- Create an edge bookmark repository, pointing at the same revision as the master bookmark.
- Rebase the required changes for Edge support on top of the revision the edge and master bookmarks point to.
- Move the edge bookmark on to include all of those Edge support commits. Make sure the master bookmark was not moved.
- Ensure that building the Edge extension actually works, I found I needed to add a metadata.edge file for example.
- Push the new bookmark and related commits to adblockpluschrome.
Attachments (0)
Change History (10)
comment:1 Changed on 11/07/2016 at 04:28:20 PM by kzar
- Blocking 4617 added
comment:2 Changed on 11/09/2016 at 03:58:14 PM by oleksandr
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 11/14/2016 at 01:03:01 PM by kzar
- Cc jsonesen added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening since the metadata.edge file wasn't added and the build doesn't work yet. If it helps here's a hacked together metadata file I used for testing. (Note you'll need to remove the comment since that breaks things and also fix the icon paths with the proper images.)
Edit: Also note I made up values such as versions, you should check all those and correct them.
comment:4 Changed on 12/01/2016 at 12:14:35 PM by kzar
- Owner set to oleksandr
- Review URL(s) modified (diff)
comment:5 Changed on 12/01/2016 at 12:15:01 PM by kzar
- Status changed from reopened to reviewing
comment:6 Changed on 01/12/2017 at 10:06:19 AM by abpbot
A commit referencing this issue has landed:
Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome...
comment:7 Changed on 01/12/2017 at 10:07:40 AM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 01/12/2017 at 10:33:22 AM by sebastian
- Resolution fixed deleted
- Status changed from closed to reopened
Sorry, but it seems there is one more thing that needs to be changed in metadata.edge. As per #4578 we need to set extension_id_release = 1.0.
comment:9 Changed on 08/24/2017 at 11:33:44 AM by oleksandr
- Resolution set to fixed
- Status changed from reopened to closed
The `extension_id_release = 1.0' change was added in #5315. Closing this.
comment:10 Changed on 09/20/2017 at 08:53:43 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
This looks done. Can create Edge builds from the adblockpluschrome directory. The extension_id_release is in the metadata.edge file.
adblockpluschrome / 1846:44197859df84
Changes have been pushed.