Opened on 11/22/2016 at 02:59:15 PM
Closed on 11/25/2016 at 08:35:24 AM
#4662 closed change (fixed)
[hgreview] Add an option for suppressing the email after upload
Reported by: | fhd | Assignee: | fhd |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas, ferris | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
hg review automatically sends an email after uploading a review. My preferred workflow is to first double check the review before sending out that mail, so I would prefer an option that suppresses it.
What to change
Add the --no_mail option to hgreview.py that suppresses the automatic email. When this option is specified, reviewers don't have to be specified for the initial upload, either.
Attachments (0)
Change History (5)
comment:1 Changed on 11/22/2016 at 03:00:30 PM by fhd
- Owner set to fhd
comment:2 Changed on 11/22/2016 at 03:02:38 PM by fhd
- Cc ferris added
comment:3 Changed on 11/22/2016 at 03:03:01 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/25/2016 at 08:34:24 AM by abpbot
comment:5 Changed on 11/25/2016 at 08:35:24 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Fixes 4662 - [hgreview Add an option for suppressing the email after upload]