Opened on 11/29/2016 at 08:42:43 AM
Closed on 08/01/2017 at 07:54:38 AM
Last modified on 08/01/2017 at 01:12:18 PM
#4669 closed change (fixed)
Mention $popup filter option on filters documentation page
| Reported by: | arthur | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | saroyanm, lisabielik, vickyyu, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by arthur)
Background
The $popup filter option is missing on the filters documentation page.
What to change
Pop-up blocking support was added to Adblock Plus for Firefox in 2011 (see announcement). It seems it was forgotten to update the filters documentation back then. It should be mentioned in the filter options as well.
Draft
$popup - pages opened in a new tab or window
Attachments (1)
Change History (21)
comment:1 Changed on 11/29/2016 at 08:43:50 AM by arthur
- Cc vickyyu added
comment:2 Changed on 12/02/2016 at 06:53:20 PM by juliandoucette
comment:3 Changed on 12/03/2016 at 11:30:22 PM by juliandoucette
- Priority changed from Unknown to P5
comment:4 Changed on 12/05/2016 at 04:43:42 PM by arthur
- Description modified (diff)
@julian
Sure, done.
comment:5 Changed on 12/05/2016 at 06:13:23 PM by juliandoucette
- Priority changed from P5 to Unknown
comment:6 Changed on 12/05/2016 at 06:30:55 PM by juliandoucette
@arthur
- Where does the draft text go?
- Is that all that is required to properly document this feature?
comment:7 Changed on 12/05/2016 at 07:52:43 PM by lisabielik
@arthur, @juliandoucette:
Should we just update all of the text on the page? There are some things that need to be fixed.
comment:8 Changed on 12/07/2016 at 12:58:10 PM by arthur
@lisa
What is it exactly? Do we have filed bugs for that?
@julian
I would suggest below the genericblock option explanation. I would say so but it wouldn't hurt if Wladimir could have a quick look I think.
comment:9 Changed on 12/07/2016 at 07:31:54 PM by lisabielik
@arthur:
I worked on this page way back when I first started but never created a ticket or got my changes updated. I *think* @jeen is having Felix review this content to assure that it is still accurate before we start the text rewrite for ABP.org. Since this is a lot to work with, I suggest we just make your proposed change and wait to update the rest of the page when we start the new ABP.org content. So nevermind my question and sorry for the confusion!
Also, where is the text change at in the file filters.html? Sorry, but I'm not seeing it?
comment:10 Changed on 01/12/2017 at 09:20:09 AM by arthur
@lisabielik
I think the filters.html represents the current state. Since Wladimir is on holidays I'll ask Thomas to have a quick look.
comment:11 Changed on 01/12/2017 at 11:10:42 AM by arthur
@juliandoucette
I got feedback from Thomas. He said that should be sufficient.
comment:12 Changed on 01/25/2017 at 08:51:09 PM by juliandoucette
- Cc greiner added
- Priority changed from Unknown to P3
- Ready set
@greiner @arthur please let me know if you think this should be a higher priority.
comment:13 Changed on 06/12/2017 at 12:26:18 PM by vickyyu
Hi guys, was this ever implemented?
comment:14 Changed on 06/14/2017 at 09:26:15 AM by arthur
@julian
It would be great if this could be added asap. Thanks!
comment:15 Changed on 07/28/2017 at 03:36:59 PM by ire
- Owner set to ire
comment:16 Changed on 07/28/2017 at 03:47:39 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:17 Changed on 08/01/2017 at 07:54:00 AM by abpbot
A commit referencing this issue has landed:
Issue 4669 - Mention filter option on filters documentation page
comment:18 Changed on 08/01/2017 at 07:54:38 AM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
comment:19 Changed on 08/01/2017 at 12:09:18 PM by arthur
Now that I see it on the page, the $ character shouldn't actually be part of it. Could someone remove it?
@arthur can you draft the text of this update? I'm guessing you know the technical details better than @lisabielik?