Opened on 12/05/2016 at 12:09:28 AM
Closed on 12/07/2016 at 11:51:42 PM
Last modified on 09/20/2017 at 08:54:54 AM
#4698 closed defect (fixed)
Text not shown in popup window on Edge
| Reported by: | oleksandr | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Adblock Plus for Edge (2be9784cc9ca)
Edge 38.14393.0.0
EdgeHTML 14.14393
Windows 10 Anniversary Update
How to reproduce
- Click on the ABP icon.
Observed behaviour
The popup opens but none of the text is displayed. (See the attached screenshot.)
Expected behaviour
The text should be displayed.
Notes
The problem appears to be caused to this bug with the Edge extension APIs. browser.i18n.getMessage does not accept an array of substitutions when called from a content script.
Attachments (1)
Change History (8)
Changed on 12/05/2016 at 12:10:47 AM by oleksandr
comment:1 Changed on 12/05/2016 at 12:27:54 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/05/2016 at 11:08:44 AM by kzar
- Description modified (diff)
- Priority changed from Unknown to P2
- Summary changed from Popup window is broken in Edge to Text not show in popup window on Edge
comment:3 Changed on 12/05/2016 at 11:14:03 AM by oleksandr
- Description modified (diff)
Added the versions, however I think the previous description made more sense. The popup page is not working. It is not merely that the text is not displayed.
comment:4 Changed on 12/05/2016 at 03:43:45 PM by kzar
- Description modified (diff)
- Summary changed from Text not show in popup window on Edge to Text not shown in popup window on Edge
Well the previous description said that the popup did not render properly and to see the screenshot. I looked at the attached screenshot and the only thing I noticed was broken was the missing text.
If there is something else that was broken with how the popup was rendered then feel free to add that to the description too. (This is why it matters to write clear issue descriptions.)
comment:5 Changed on 12/07/2016 at 11:50:44 PM by abpbot
A commit referencing this issue has landed:
Issue 4698 - Popup window is broken in Edge
comment:6 Changed on 12/07/2016 at 11:51:42 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 09/20/2017 at 08:51:18 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Popup looks to be displaying and working fine now in Edge.
ABP 0.9.11.1849
Edge 40 / Windows 10
Updated the description and title for you. Mind adding Windows and Edge versions so I can mark this as ready?