Opened on 12/05/2016 at 05:24:54 AM
Closed on 10/11/2017 at 07:37:29 AM
#4699 closed defect (fixed)
Edge does not support 16px and 32px icons
| Reported by: | oleksandr | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | externaldependency |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | #5767 | Platform: | Edge |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29366791/ |
||
Description
Using browserAction.setIcon we are currently setting an icon with these sizes: 16px, 19px, 20px, 32px, 38px, 40px. If that fails we only resort to 19px and 38px. However Edge supports 19px, 20px, 38px, 40px, and it throws an exception if passed anything other than those sizes, causing us to use suboptimal icon size. We should support all icon sized of Edge.
Attachments (0)
Change History (12)
comment:1 Changed on 12/05/2016 at 05:25:33 AM by oleksandr
- Summary changed from Edge does not support 16px and 32px to Edge does not support 16px and 32px icons
comment:2 Changed on 12/05/2016 at 05:30:18 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/05/2016 at 03:48:12 PM by kzar
- Priority changed from Unknown to P4
comment:4 Changed on 12/05/2016 at 04:23:08 PM by kzar
- Priority changed from P4 to Unknown
- Ready unset
Unmarking this as ready since it's not clear how we should proceed yet. (See discussion in the codereview.)
comment:5 Changed on 12/12/2016 at 02:36:47 PM by oleksandr
There is a related issue in Edge bug tracker on this here
comment:6 Changed on 03/16/2017 at 09:36:43 AM by kzar
- Cc kzar sebastian added
- Keywords externaldependency added
According to that issue the Edge team are going to fix this their end, so looks like we can just wait.
comment:7 Changed on 09/26/2017 at 12:11:18 PM by Ross
Not sure of the state of this one? The icon used as the browser icon seems to be 40px.
ABP 0.9.11.1849
Edge 40 / Windows 10
comment:8 Changed on 09/26/2017 at 05:43:30 PM by sebastian
Microsoft Edge uses icons in 20px (low-res) and 40px (high-res). We provide icons in these dimensions, along icons in other sizes required by other browsers. However, providing the icon as well in these other sizes causes errors on Microsoft Edge. While this can be considered a bug in Microsoft Edge, according to Ollie, it hasn't been fixed on their end yet, so we finally might have to implement a workaround.
comment:10 Changed on 09/27/2017 at 07:38:33 PM by oleksandr
- Blocking 5767 added
comment:11 Changed on 09/27/2017 at 10:21:59 PM by abpbot
A commit referencing this issue has landed:
Issue 4699 - Edge does not support 16px and 32px icons
comment:12 Changed on 10/11/2017 at 07:37:29 AM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
Please file an issue with the Edge guys about this, they should ignore unused resolutions instead of throwing an exception.