Opened on 12/07/2016 at 12:53:32 PM
Closed on 12/07/2016 at 12:59:30 PM
Last modified on 03/15/2017 at 08:42:40 AM
#4714 closed defect (fixed)
"Block element" context menu item fails to open window
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Firefox 53.0a1 nightly
Adblock Plus 1.12.4.1695 WebExt development build
How to reproduce
- Go to heise.de
- Right-click one of the images and choose "Block element"
Observed behaviour
No composer window opens, error message "Error: Type error for parameter createData (Property "focused" is unsupported by Firefox) for windows.create." shows up in Browser Console.
Expected behaviour
The composer window should open successfully.
Background
Firefox currently won't allow creating unfocused windows (bug 1253129), and it will error out if focused property is present - regardless of the value. However, we want to open a focused window and that's the default behavior in both Firefox and Chrome even though the documentation doesn't really make it clear (for Chrome the unit tests clearly show what the expected behavior is).
What to change
Omit focused parameter when creating windows since the window being focused is the default anyway.
Attachments (0)
Change History (6)
comment:1 Changed on 12/07/2016 at 12:56:30 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/07/2016 at 12:57:24 PM by kzar
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 12/07/2016 at 12:58:59 PM by abpbot
comment:4 Changed on 12/07/2016 at 12:59:30 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/07/2016 at 12:59:46 PM by trev
- Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-for-Chrome-Opera-next
comment:6 Changed on 03/15/2017 at 08:42:40 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed and working as expected in FF WebEx too.
ABP 1.12.4.1741
Firefox 52 / Windows 10
Firefox Nightly (53) / Windows 10
ABP 1.12.4.1739
Chrome 49 / 56 / Windows 10
Chrome 56 / OS X 10.12
Chrome 56 / Ubuntu 16.04
Opera 37 / 41 / Windows 7
Safari 10 / OS X 10.12
A commit referencing this issue has landed:
Issue 4714 - "Block element" context menu item fails to open window