Opened on 12/07/2016 at 01:49:23 PM

Closed on 03/21/2017 at 07:38:25 PM

Last modified on 03/22/2017 at 03:14:03 PM

#4715 closed defect (fixed)

Update metadata to include antiadblockInit.js from adblockplusui instead of adblockpluscore

Reported by: wspee Assignee: wspee
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By: #3672, #4659
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29376774/

Description (last modified by sebastian)

Background

#4762 and #4136 updated the adblockpluscore and adblockplusui dependency respectively, along other changes, moving antiadblockInit.js from adblockpluscore to adblockplusui (#3672). This change, however, isn't reflected in metadata.common yet, causing the build to fail.

Note that this issue was originally about updating the dependencies and performing the required downstream changes in one go. But unfortunately, the adblockpluscore dependency got already updated independently by #4762 without the necessary adaptions.

What to change

Update metadata.common to include antiadblockInit.js from adblockplusui instead from adblockpluscore.

Attachments (0)

Change History (12)

comment:1 Changed on 12/07/2016 at 02:24:59 PM by wspee

  • Blocked By 4569 added
  • Priority changed from P2 to Unknown

comment:2 Changed on 12/07/2016 at 02:26:44 PM by wspee

  • Cc sebastian kzar added

comment:3 Changed on 12/07/2016 at 02:49:23 PM by wspee

  • Blocked By 4659 added; 4569 removed

comment:4 Changed on 12/20/2016 at 08:11:41 AM by wspee

  • Description modified (diff)

comment:5 Changed on 02/21/2017 at 11:19:32 AM by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 02/21/2017 at 11:19:54 AM by wspee

  • Type changed from defect to change

comment:7 Changed on 02/21/2017 at 12:30:02 PM by abpbot

A commit referencing this issue has landed:
​Issue 4715 - Fixing previous commit, consider dependency update importing issue 3672 changes properly

comment:8 Changed on 03/01/2017 at 10:29:19 AM by wspee

  • Milestone set to Adblock-Plus-1.13-for-Chrome-Opera

comment:9 Changed on 03/21/2017 at 07:38:25 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 03/22/2017 at 02:41:32 PM by wspee

  • Description modified (diff)
  • Summary changed from Update adblockpluscore and adblockplusui dependency to TBA to Update metadata to include antiadblockInit.js from adblockplusui instead of adblockpluscore

comment:11 Changed on 03/22/2017 at 03:02:12 PM by sebastian

  • Description modified (diff)
  • Type changed from change to defect

comment:12 Changed on 03/22/2017 at 03:14:03 PM by sebastian

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from wspee.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.