Opened on 12/09/2016 at 06:11:49 AM

Closed on 10/19/2017 at 10:19:26 AM

#4720 closed change (fixed)

Edge packager does not support devenv

Reported by: oleksandr Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, kvas, tlucas Blocked By:
Blocking: #5383 Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29367148/
https://codereview.adblockplus.org/29575633/

Description (last modified by tlucas)

In #4028 we have added support for packaging Edge extensions. However support for devenv was not added. It is much easier to develop and test builds using the development environment. Since there are apparently no more differences in what we include in a devenv for Chrome and Edge, we should add support for devenv for Edge too.

Make sure the build script supports creating Edge devenv, by something like:
build.py -t edge devenv

Attachments (0)

Change History (8)

comment:1 Changed on 12/09/2016 at 06:24:03 AM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/20/2017 at 07:23:47 PM by sebastian

  • Cc tlucas added
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 10/13/2017 at 01:40:26 PM by tlucas

  • Owner set to tlucas

comment:4 Changed on 10/13/2017 at 03:02:30 PM by tlucas

  • Review URL(s) modified (diff)

comment:5 Changed on 10/16/2017 at 09:38:10 AM by tlucas

  • Description modified (diff)

comment:6 Changed on 10/18/2017 at 09:16:12 AM by tlucas

  • Blocking 5383 added

comment:7 Changed on 10/19/2017 at 10:18:40 AM by abpbot

A commit referencing this issue has landed:
Issue 4720 - enable devenv target for Edge packager

comment:8 Changed on 10/19/2017 at 10:19:26 AM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
 
Note: See TracTickets for help on using tickets.