Opened on 07/06/2017 at 02:31:38 PM
Closed on 10/22/2017 at 11:33:55 AM
Last modified on 10/08/2019 at 05:53:19 PM
#5383 closed change (fixed)
Add tests for the Chrome and Firefox packagers
| Reported by: | sebastian | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | kzar, tlucas | Blocked By: | #4720, #5535 |
| Blocking: | #5484 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Currently, the only tests we have for buildtools only cover the packager for Microsoft Edge, however, not the other relevant build targets (i.e. Chrome and Firefox).
Moreover, the existing tests for the Edge packager are mostly testing the packager's internal APIs, however, not whether these are correctly integrated in the build process.
What to change
Add tests for the build process of Chrome and Gecko/WebExt extensions, and update existing tests for Edge extensions. Wherever possible functionality should be tested end-to-end as part of the build process, and not by calling internal APIs.
Attachments (0)
Change History (14)
comment:1 Changed on 07/06/2017 at 02:31:45 PM by sebastian
- Summary changed from Add tests for the Chrome and Firefox packagers. to Add tests for the Chrome and Firefox packagers
comment:2 Changed on 07/13/2017 at 02:36:49 PM by tlucas
- Cc tlucas added
comment:3 Changed on 07/17/2017 at 10:44:07 AM by tlucas
- Owner set to tlucas
comment:5 Changed on 08/02/2017 at 10:53:19 AM by tlucas
- Status changed from new to reviewing
comment:6 Changed on 08/11/2017 at 12:36:12 PM by sebastian
- Blocking 5484 added
comment:8 Changed on 08/16/2017 at 09:18:31 AM by tlucas
- Status changed from reviewing to reopened
comment:9 Changed on 09/15/2017 at 12:53:15 PM by tlucas
- Status changed from reopened to reviewing
comment:10 Changed on 10/13/2017 at 09:57:16 AM by tlucas
- Blocked By 5535 added
comment:11 Changed on 10/18/2017 at 09:16:12 AM by tlucas
- Blocked By 4720 added
comment:12 Changed on 10/22/2017 at 11:32:53 AM by abpbot
A commit referencing this issue has landed:
Issue 5383 - Add tests for the Chrome and Firefox packagers
comment:13 Changed on 10/22/2017 at 11:33:55 AM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 06/29/2019 at 06:03:52 AM by lucasashton
spam
The usage of webpack severly changes the way how the packagers behave. I expect #5535 to land soon (at least before this issue lands) - so it wouldn't make sense to have this not being blocked by #5535.