Opened on 05/13/2014 at 03:01:08 PM
Closed on 06/16/2014 at 10:27:48 AM
Last modified on 06/16/2014 at 12:05:22 PM
#473 closed defect (fixed)
aborting non-respondent installation leads to empty user interaction window
| Reported by: | philll | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.2-for-Internet-Explorer |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | ie_devbuild_1.2 |
| Cc: | smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by mapx)
Environment
Win 7 / 8
IE 11.0.9600.17105
ABP 1.2 dev
How to reproduce
- Get the installer non-respondent at the first installation step
- Click the window's close button
Observed behaviour
The user is presented the window shown in attachment:ie_1_2_cancel_installer_empty.png
Please note that the installer gets non-respondent every other try but I didn't find a reproducible trigger so far.
Expected behaviour
If some user input is required, there should be a visible information text to it.
Attachments (1)
Change History (10)
Changed on 05/13/2014 at 03:01:22 PM by philll
comment:2 Changed on 05/13/2014 at 04:43:15 PM by mapx
- Description modified (diff)
- Summary changed from aborting non-repsondant installation leads to empty user interaction window to aborting non-respondent installation leads to empty user interaction window
comment:3 Changed on 05/13/2014 at 04:43:41 PM by mapx
- Cc smultron45@gmail.com added
comment:4 Changed on 05/15/2014 at 03:32:06 PM by philll
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 05/29/2014 at 07:03:05 AM by oleksandr
- Owner set to oleksandr
comment:6 Changed on 06/05/2014 at 01:12:29 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-next
comment:7 Changed on 06/12/2014 at 09:04:40 AM by philll
- Keywords ie_devbuild_1.2 added; devbuild_1.2 removed
comment:8 Changed on 06/16/2014 at 10:27:48 AM by oleksandr
- Resolution set to fixed
- Status changed from new to closed
Burn UI was eating our Custom Action UI, but still expecting input. So the installation would hang every time IE with ABP enabled is open. We've resolved this by moving away from Burn to InnoSetup:
https://hg.adblockplus.org/adblockplusie/rev/b08d8e926c13
comment:9 Changed on 06/16/2014 at 12:05:22 PM by trev
Follow-up commits:
https://hg.adblockplus.org/adblockplusie/rev/1c655c0e0f54
https://hg.adblockplus.org/adblockplusie/rev/3945587815d1
https://hg.adblockplus.org/adblockplusie/rev/017e470c2b6e
https://hg.adblockplus.org/adblockplusie/rev/35556c05a67f
https://hg.adblockplus.org/adblockplusie/rev/ef810cb30891
https://hg.adblockplus.org/adblockplusie/rev/854d8a5bc6e7
https://hg.adblockplus.org/adblockplusie/rev/853872022742
https://hg.adblockplus.org/adblockplusie/rev/535da7337da4
It becomes whenever there is an IE instance around. It displays a custom action UI and waits on an input there. Unfortunately the UI is not topmost, which needs to be fixed