Opened on 12/15/2016 at 02:11:57 PM
Closed on 08/07/2017 at 02:54:20 PM
Last modified on 09/13/2017 at 07:38:51 PM
#4738 closed change (fixed)
[UI] Redesign website view
| Reported by: | mario | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-2.0.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4706 | Platform: | Adblock Browser for iOS |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
This issue is part of ABB's redesign as described under #4706.
Existing logic/UI which is not covered within this issue stays in place as it is.
What to change
Logic
- If the website can be navigated back, mark the back-icon in the bottom bar as active
- If the website can be navigated forward, mark the forward-icon in the bottom bar as active
- If the website can not be navigated back, mark the back-icon in the bottom bar as inactive
- If the website can not be navigated forward, mark the forward-icon in the bottom bar as inactive
Attachments
Style Guides
Assets
Attachments (5)
Change History (13)
Changed on 12/16/2016 at 11:36:42 AM by mario
Changed on 12/16/2016 at 11:36:53 AM by mario
comment:3 Changed on 01/18/2017 at 01:11:34 PM by mario
- Priority changed from Unknown to P2
comment:4 Changed on 06/19/2017 at 03:27:47 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed on 07/10/2017 at 07:52:04 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Changed on 07/25/2017 at 09:15:31 PM by traynard
Changed on 07/25/2017 at 09:16:09 PM by traynard
Image 2: The website still shows the bookmark star highlighted
Changed on 07/25/2017 at 09:16:41 PM by traynard
Image 3: Even though this site is not bookmarked, my option is "Remove Bookmark"
comment:6 Changed on 07/25/2017 at 09:17:28 PM by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
When deleting a bookmark, ABB still remembers it and renders it on the website view.
Steps to Reproduce:
-Bookmark a website (youtube.com used in attached examples)
-Remove the bookmarked site
-Open a new tab and navigate to the site
Notice the bookmark star is highlighted and in the hamburger menu, it shows "Remove Bookmark"
Looks like the bookmark is being cached.
comment:7 Changed on 08/07/2017 at 02:54:20 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:8 Changed on 09/13/2017 at 07:38:51 PM by traynard
- Verified working set
Image 1: Bookmarks currently saved in ABB (after removal of youtube)