Opened on 01/11/2017 at 05:02:50 AM
Closed on 08/29/2019 at 05:48:47 PM
#4789 closed change (rejected)
Migrate to the new Chrome options UI
| Reported by: | kzar | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sebastian, greiner, mapx, wspee | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Since Chrome 40 the second version of the options API has been available. For backwards compatibility a open_in_tab option was provided but it is deprecated and we should probably stop using it.
From the API docs:
This is only useful to delay the inevitable deprecation of the old options UI! It will be removed soon, so try not to use it. It will break.
What to change
Remove the open_in_tab option. Ensure our options page continues to work properly when using the new Chrome options UI.
Attachments (0)
Change History (4)
comment:1 Changed on 01/11/2017 at 05:16:54 AM by kzar
- Description modified (diff)
- Summary changed from Migrate to the new Chrome options API to Migrate to the new Chrome options UI
comment:2 Changed on 03/16/2017 at 09:15:26 AM by kzar
- Priority changed from Unknown to P4
- Ready set
comment:3 Changed on 03/16/2017 at 09:49:31 AM by sebastian
- Cc wspee added
I guess we can wait for the new options page before migrating to inline options (i.e. open_in_tab=false). However, then again we should keep in mind, when designing the new options page, that it won't be shown as a separate tab, but will be embedded in Chrome's settings, in the future.
comment:4 Changed on 08/29/2019 at 05:48:47 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Whoops, we already did use the new API but passed the deprecated open_in_tab option. I've updated the issue.