Opened on 01/12/2017 at 10:36:47 AM
Closed on 07/26/2017 at 01:36:23 PM
#4790 closed change (fixed)
List web.acceptableads.com in the Adblock Plus repositories list
| Reported by: | saroyanm | Assignee: | ferris |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | juliandoucette | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We have created the repository for acceptableads.com during the development phase by #4268, but we don't yet list it in the repositories list.
What to change
- List web.acceptableads.com in mercurial repositories list.
- Create a Github repository if the one doesn't exist yet and sync with the Mercurial one above.
Attachments (0)
Change History (15)
comment:1 Changed on 02/09/2017 at 02:53:51 PM by ferris
- Owner set to ferris
comment:2 Changed on 02/21/2017 at 09:25:09 AM by matze
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 03/27/2017 at 09:13:40 AM by saroyanm
comment:4 follow-up: ↓ 5 Changed on 03/27/2017 at 09:53:59 PM by ferris
It's being postponed due to ever more other things on our plate. If you say it's urgent, I'll usher it in ahead of some other things. If not, it'll be postponed till the day developers can create and share repositories autonomously (think self-service repo management).
comment:5 in reply to: ↑ 4 Changed on 03/28/2017 at 09:18:56 AM by saroyanm
Replying to ferris:
It's being postponed due to ever more other things on our plate. If you say it's urgent, I'll usher it in ahead of some other things.
It's not urgent, but nice to have, so it's not urgent.
If not, it'll be postponed till the day developers can create and share repositories autonomously (think self-service repo management).
Can developers do that now ? Considering the mirroring with Mercurial repository and etc. If so I'll be happy to do that.
comment:6 follow-up: ↓ 7 Changed on 03/28/2017 at 08:25:02 PM by ferris
OK, thanks for the input.
Can developers do that now ? Considering the mirroring with Mercurial repository and etc. If so I'll be happy to do that.
No, I believe that the setup of github synced repos is limited to those with sudo permissions on the mercurial server. Still haven't learnt/figured out how to set those up tho. As soon as I do, it's probably a 5 min thing.
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed on 03/29/2017 at 11:09:41 AM by saroyanm
Replying to ferris:
OK, thanks for the input.
Can developers do that now ? Considering the mirroring with Mercurial repository and etc. If so I'll be happy to do that.
No, I believe that the setup of github synced repos is limited to those with sudo permissions on the mercurial server. Still haven't learnt/figured out how to set those up tho. As soon as I do, it's probably a 5 min thing.
I see, I thought this might be helpful just in case -> https://issues.adblockplus.org/ticket/2899 there is a codereview that I can't access, but it might be relevant, because this was part of discussion.
comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed on 03/30/2017 at 10:29:48 AM by ferris
Replying to saroyanm:
I thought this might be helpful just in case -> https://issues.adblockplus.org/ticket/2899 there is a codereview that I can't access, but it might be relevant, because this was part of discussion.
Cool, perhaps I can fix both tickets in one go. I also cannot see the codereview btw.
comment:9 in reply to: ↑ 8 ; follow-up: ↓ 10 Changed on 03/30/2017 at 10:46:18 AM by saroyanm
Replying to ferris:
Replying to saroyanm:
I thought this might be helpful just in case -> https://issues.adblockplus.org/ticket/2899 there is a codereview that I can't access, but it might be relevant, because this was part of discussion.
Cool, perhaps I can fix both tickets in one go. I also cannot see the codereview btw.
As a note: the ticket I referenced is already fixed.
comment:10 in reply to: ↑ 9 ; follow-up: ↓ 11 Changed on 03/30/2017 at 10:56:31 AM by ferris
Replying to saroyanm:
As a note: the ticket I referenced is already fixed.
But I thought Matze is still waiting for a ping there, ref his last comment:
Synchronization has been prepared, drop me a note via mail or IRC when it needs to become activated (which includes publishing the Mercurial repository and creating the GitHub one).
Is this already done? The comment came after the ticket as closed.
comment:11 in reply to: ↑ 10 ; follow-up: ↓ 12 Changed on 03/30/2017 at 11:01:54 AM by saroyanm
Replying to ferris:
Replying to saroyanm:
As a note: the ticket I referenced is already fixed.
But I thought Matze is still waiting for a ping there, ref his last comment:
Synchronization has been prepared, drop me a note via mail or IRC when it needs to become activated (which includes publishing the Mercurial repository and creating the GitHub one).
Is this already done? The comment came after the ticket as closed.
Yes, it's fixed -> https://github.com/adblockplus/web.adblockbrowser.org
comment:12 in reply to: ↑ 11 Changed on 03/30/2017 at 11:37:36 AM by ferris
Replying to saroyanm:
Yes, it's fixed -> https://github.com/adblockplus/web.adblockbrowser.org
Great. Then I know where I can reverse-engineer the sync setup :)
comment:13 Changed on 07/25/2017 at 06:07:31 PM by matze
The repo is listed with the index now, and we do not actually plan to publish it on GitHub (at least not in the ABP organization). Do you need it to be available there for your workflow?
comment:14 Changed on 07/26/2017 at 12:21:47 PM by juliandoucette
Do you need it to be available there for your workflow?
No.
comment:15 Changed on 07/26/2017 at 01:36:23 PM by ferris
- Resolution set to fixed
- Status changed from new to closed
Any updates regarding this ticket ?