Opened on 02/13/2017 at 12:06:20 PM
Closed on 02/13/2017 at 02:45:43 PM
#4882 closed change (fixed)
Rename flake8-abp to flake8-eyeo
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | kzar, kvas | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29375591/ |
||
Description
Background
During the implementation of eslint-config-eyeo (#3692, our JavaScript linter configuration) we decided against the -abp, for the -eyeo, suffix. This has been established as not all of the code to be linted is part of Adblock Plus, but always developed by Eyeo. This is even more true for our Python code. Hence we decided to rename flake8-abp to flake8-eyeo as well.
What to change
- Rename flake-abp to flake8-eyeo, in the codingtools repository.
- Adapt the deps in the tox.ini of sitescripts, buildtools, cms and python-abp.
- Adapt the link on https://adblockplus.org/coding-style.
Attachments (0)
Change History (10)
comment:1 Changed on 02/13/2017 at 01:05:13 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 02/13/2017 at 02:32:51 PM by abpbot
comment:5 Changed on 02/13/2017 at 02:32:51 PM by abpbot
A commit referencing this issue has landed:
Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming
comment:6 Changed on 02/13/2017 at 02:32:52 PM by abpbot
A commit referencing this issue has landed:
Issue 4882 - Adapted link for flake8-abp to flake8-eyeo renaming, and added missing <fix> tags
comment:7 Changed on 02/13/2017 at 02:32:53 PM by abpbot
A commit referencing this issue has landed:
Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming
comment:8 Changed on 02/13/2017 at 02:32:53 PM by abpbot
A commit referencing this issue has landed:
Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming
comment:9 Changed on 02/13/2017 at 02:32:54 PM by abpbot
A commit referencing this issue has landed:
Issue 4882 - Adapted deps in tox.ini for flake8-abp to flake8-eyeo renaming
comment:10 Changed on 02/13/2017 at 02:45:43 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 4882 - Renamed flake8-abp to flake8-eyeo