event-based error reporting description misleading

[scheer]

With the implementation of #4672 and #3272 we introduced error and crash reporting to Adblock Browser. Both features contain a modal dialog which reads 'Adblock Unexpectedly Quit. Would you like to send a report to fix the problem?'. The headline should be reworded to read "Adblock Browser". On top of that the additional sentence appears to be misleading, as it implies that if the user clicks the 'Send Report' button, that the issue will be automatically fixed.

I would suggest to change the headline and a slightly different description elaborating that, clicking the 'Send Report' button would, in fact, help us to fix the issue, and not directly fix the issue. The suggested sentence would be 'Would you like to send a report to help us try and fix the problem?'.

Environment

ABB 1.5.2 (1409)
iPhone 6s Plus
iOS 10.2

What to change

In all three instances:

• In the crash report notification (start ABB 1.5.1, navigate to "Settings" -> "Devbuild Settings" -> "Crash application now")
• In the error report notification (start ABB 1.5.1, navigate to "Settings" -> "Devbuild Settings" -> "Produce error now")
• In the start-up error report notification (start ABB 1.5.1, navigate to "Settings" -> "Devbuild Settings" -> "Next App Start Failure")

replace the following text:

• Replace Adblock Unexpectedly Quit with Adblock Browser Unexpectedly Quit
• Replace Would you like to send a report to fix the problem? with Would you like to send a report to help us try and fix the problem?

[mario]

@Lisa, would you mind reviewing the suggested text change? IMHO it makes sense to be more specific -- as suggested -- in order to avoid misinterpretation.

[lisabielik]

@Mario

proposed text LGTM

[mario]

Thanks, Lisa!

[mario]

Expanded the scope of this issue to fix the erroneous sentence in all occurrences. Furthermore included "Adblock" to be replaced by "Adblock Browser" now that we have the possibility to change that text. (It came from HockeyApp and wasn't changeable before)

Pending review for the changes in the headline.

[lisabielik]

@mario:

Everything LGTM

[mario]

Thanks Lisa!