Opened on 02/21/2017 at 06:06:23 AM
Closed on 03/29/2017 at 12:36:36 PM
Last modified on 04/18/2019 at 08:34:46 AM
#4919 closed change (fixed)
Make getBackupFiles in lib/filterStorage.js asynchronous
| Reported by: | kzar | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | trev, sebastian, wspee | Blocked By: | |
| Blocking: | #5048 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
The getBackupFiles function in lib/filterStorage.js currently has a comment // TODO: This method should be asynchronous. Since we're now beginning to use ESLint for the codebase (#4878) we need to remove that comment.
What to change
Make getBackupFiles asynchronous.
Attachments (0)
Change History (7)
comment:1 Changed on 02/21/2017 at 08:43:10 AM by trev
comment:2 Changed on 02/21/2017 at 09:33:20 AM by sebastian
Well, Adblock Plus for Safari is deprecated and no longer targeted by adblockpluscore, Microsoft Edge is about to lift their storage limitations with the upcoming Windows Creators Update, and as far as I can tell, there are no storage limitations on Chrome and Firefox with WebExtensions.
But the UI argument remains. If there is no plan to add this backup functionality to the new options page, there is not much of a point to keep this logic around or to even improve it. To clarify, is this about backups stored inside the extension, or about backups to be exported out of the browser?
comment:3 Changed on 03/29/2017 at 10:14:04 AM by trev
- Blocking 5048 added
- Owner set to trev
- Priority changed from Unknown to P2
- Ready set
This is blocking #5048 now - not going via io.js here means that our legacy extension cannot use WebExtensions storage.
comment:4 Changed on 03/29/2017 at 10:24:23 AM by wspee
- Cc wspee added
comment:5 Changed on 03/29/2017 at 10:39:31 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 03/29/2017 at 12:36:23 PM by abpbot
A commit referencing this issue has landed:
Issue 4919 - Make getBackupFiles in lib/filterStorage.js asynchronous
comment:7 Changed on 03/29/2017 at 12:36:36 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
The other option is to remove that functionality. As it is now, we only create automatic backups on Firefox, on all other platforms we cannot do it because of storage space (and UI) limitations. Given that the Firefox codebase is going away, improving this would be pointless.